Inconsistent Element object in FluidField.on
Developer Preview
I just notice that in the event FluidField.on('field_type', 'add') the element is a jQuery object and in the other events a DOM element.
I would be better to make it or a jQuery object or a DOM element, but not mixed… I suggest a jQuery object 😊
I’m looking at the code and every FluidField triggered event should be passing a jQuery object. I’m not seeing a mismatch anywhere. Can you elaborate on what you are seeing?
Hi Seth,
I console.log the element in the events: https://www.dropbox.com/s/ytc7lis1pbe1ab2/fluid.png?dl=0
Doing a .find() on a element; add succeed and the rest failed Uncaught TypeError: element.find is not a function
Ah. It looks like the sorting events are not returning jQuery objects. On line 72 and 82 of themes/ee/asset/javascript/src/fields/fluid_field/cp.js can you change them to be FluidField.fireEvent($(ui.item).data('field-type'), 'beforeSort', $(ui.item)) and FluidField.fireEvent($(ui.item).data('field-type'), 'afterSort', $(ui.item)) respectively and let me know if that resolves it for you?
Yes thanks!