We use cookies to improve your experience. No personal information is gathered and we don't serve ads. Cookies Policy.

ExpressionEngine Logo ExpressionEngine
Features Pricing Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University
Log In or Sign Up
Log In Sign Up
ExpressionEngine Logo
Features Pro new Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University Blog
  • Home
  • Forums

[EE 3.4.0] - file modal bug

Developer Preview

Mark Croxton's avatar
Mark Croxton
319 posts
8 years ago
Mark Croxton's avatar Mark Croxton

When trying to embed an image or file in a rich text field or standalone file field, and you try to select a filter (such as the directory) the modal closes immediately before you can select an image/file.

       
Kevin Cupp's avatar
Kevin Cupp
791 posts
8 years ago
Kevin Cupp's avatar Kevin Cupp

I’m unable to reproduce this one, Mark. Any JavaScript errors? Is this an install you’ve upgraded or a fresh install? If you’ve upgraded, can you make sure the JS got overwritten properly?

       
Mark Croxton's avatar
Mark Croxton
319 posts
8 years ago
Mark Croxton's avatar Mark Croxton

It’s a fresh install. No JS errors in console, and it happens in Chrome and Firefox. Attached a screenshot showing you the modal as launched from a file field. Clicking the highlighted button causes the modal to close and the page reloads.

       
Mark Croxton's avatar
Mark Croxton
319 posts
8 years ago
Mark Croxton's avatar Mark Croxton

Doesn’t look like file attachment is working in this forum

       
Derek Jones's avatar
Derek Jones
7,561 posts
8 years ago
Derek Jones's avatar Derek Jones

You can attach images, 200kb, 1000x800 max. For anything larger, you can use DropBox, Cloud.ly, etc. and use Markdown image syntax to render inline.

       
Mark Croxton's avatar
Mark Croxton
319 posts
8 years ago
Mark Croxton's avatar Mark Croxton

Ah ha. Here you go:

       
Kevin Cupp's avatar
Kevin Cupp
791 posts
8 years ago
Kevin Cupp's avatar Kevin Cupp

Thanks, Mark. I dug in a little further and I couldn’t reproduce because it had already been fixed in our repo. Here is the fix if you want to apply it to your end:

Open themes/ee/asset/javascript/src/common.js and find this code on line 108:

$('.has-sub').on('click',function(){

And REPLACE it with:

$('body').on('click', '.has-sub', function(){

Let us know if you have any more trouble there.

       
Mark Croxton's avatar
Mark Croxton
319 posts
8 years ago
Mark Croxton's avatar Mark Croxton

Works a treat - thanks!

       

Reply

Sign In To Reply

ExpressionEngine Home Features Pro Contact Version Support
Learn Docs University Forums
Resources Support Add-Ons Partners Blog
Privacy Terms Trademark Use License

Packet Tide owns and develops ExpressionEngine. © Packet Tide, All Rights Reserved.