We use cookies to improve your experience. No personal information is gathered and we don't serve ads. Cookies Policy.

ExpressionEngine Logo ExpressionEngine
Features Pricing Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University
Log In or Sign Up
Log In Sign Up
ExpressionEngine Logo
Features Pro new Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University Blog
  • Home
  • Forums

Extension to remove the 'Quick Save' button (and more!)

Development and Programming

Adrienne L. Travis's avatar
Adrienne L. Travis
213 posts
18 years ago
Adrienne L. Travis's avatar Adrienne L. Travis

Ummm, why shouldn’t Mark use someone else’s publicly posted code and make improvements to it? He wasn’t claiming the work as his own.

–Adrienne

       
Mark Huot's avatar
Mark Huot
587 posts
18 years ago
Mark Huot's avatar Mark Huot

Yes, but my version effectively splits the development into two branches. Say what I did didn’t mesh with what Travis did (not that that’s likely, but the point still stands) now you would have two separate builds of essentially the same extension. This could lead to some confusion and certainly upgrade issues if you try to flip flop between the two branches.

       
Mark Huot's avatar
Mark Huot
587 posts
18 years ago
Mark Huot's avatar Mark Huot

If anyone’s curious the reason I posted the update to travis’ code was because it was interfering with my “File” extension: http://ellislab.com/forums/viewthread/38997/P18/#186810

       
Lisa Wess's avatar
Lisa Wess
20,502 posts
18 years ago
Lisa Wess's avatar Lisa Wess

Just as a note, publicly posted does not mean GPL or Open Source, so it might not be distributable. Just something to consider for alienne, I’m sure Mark knows about software licensing =)

       
Mark Huot's avatar
Mark Huot
587 posts
18 years ago
Mark Huot's avatar Mark Huot

Yup, thanks for the legal lingo Lisa. I’ve since removed the post.

       
Sue Crocker's avatar
Sue Crocker
26,054 posts
18 years ago
Sue Crocker's avatar Sue Crocker

Suggesting improvements to code is certainly within the realm of what Mark can do, but the change file needs to come from the person who originally posted it. I certainly don’t want to deal with version/author confusion.

Many of us have posted potential changes to the code as “hacks” but we don’t redistribute other people’s code.

Inside the original code:

THIS IS COPYRIGHTED SOFTWARE
 All RIGHTS RESERVED
 Written by: Travis Smith
 Copyright (c) 2006 Hop Studios
 http://www.hopstudios.com/
--------------------------------------------------------
 Please do not distribute this extension without written
 consent from the author.

Added: Hopefully Travis will be able to take the changes Mark suggested, and add a newer version for us to use.

Mark, we really do appreciate your work on the extensions you’ve done. Thanks in advance for working with Travis to get an improved version of his extension out there.

       
Adrienne L. Travis's avatar
Adrienne L. Travis
213 posts
18 years ago
Adrienne L. Travis's avatar Adrienne L. Travis

Sue, i’m aware of software licensing too, being an IT professional myself, and i know that publicly posted doesn’t mean GPL’d. It was your TONE i thought was uncalled for, mostly, and that i was trying (perhaps badly) to call attention to. Mark was trying to be helpful, and is in general HUGELY helpful, and i thought you were rude.

However, you’re a Big Name EE Person and i’m a peon, so what do i know?

       
Sue Crocker's avatar
Sue Crocker
26,054 posts
18 years ago
Sue Crocker's avatar Sue Crocker

ailenne, I’m sorry if you were offended by my tone. I agree that Mark was trying to be helpful and he is doing a great service to the community.

I’m really not a big name EE person. I’m just a user such as yourself. In fact, we both started posting in here in 2002. 😊

So please accept my apology for my tone.

       
Paul Burdick's avatar
Paul Burdick
480 posts
18 years ago
Paul Burdick's avatar Paul Burdick

One’s name matters little here, their opinion and knowledge is where the weight is. I actually found Sue’s post(s) about this honest and not rude. She merely posted a question and information about the license. Not sure there was any real tone there, alienne.

       
Hop Studios's avatar
Hop Studios
459 posts
18 years ago
Hop Studios's avatar Hop Studios

Just so everyone’s clear – I think it’s nice that Mark wanted to be helpful and improve my extension, and we’ve chatted offline.

While I’d been meaning to update the extension anyway, I hadn’t planned to do so today. But seeing as there’s a bit of interest, I’ve upgraded it to version 1.1 – see the first post in this thread for the latest file. In this version, I… * added link on CP home page that lets users edit that home page * added settings for each individual modification * added a language file * added version notes * fixed it so that it integrates better with other extensions

Version 1.1 is still free, but as Sue notes, I do still want to keep the copyright.

TTFN Travis

       
Adrienne L. Travis's avatar
Adrienne L. Travis
213 posts
18 years ago
Adrienne L. Travis's avatar Adrienne L. Travis

Sue,

I’m sorry i snarked at you – it was uncalled for. I was having a really bad day yesterday, and i blew the whole incident WAY out of proportion. Thanks for being more of a grownup than i was being. wry grin

–Adrienne

       
Lisa Wess's avatar
Lisa Wess
20,502 posts
18 years ago
Lisa Wess's avatar Lisa Wess

Wiki’d. Feel free to add a description there if you want. I haven’t used it and lost track of what all it does. 😉

       
Rob Quigley's avatar
Rob Quigley
236 posts
18 years ago
Rob Quigley's avatar Rob Quigley

Nice extension. My feedback is that I’d like to see additional options to hide the “Preview” button and the “File Upload” button. Here’s two scenerios where this would be helpful:

1) Normally I have a lot of miscellanious custom fields on a publish page or have styled the output content in the actual web page in such a way that the “Preview” really is meaningless for the viewer (a big jumble of content that doesn’t show how the content and images will work on the actual page). I’m also using an extension that adds links to view the entry directly from the control panel as well as when saving the entry so the user has the option to preview (if saved as draft) the content as it will appear in the actual web page so the default preview button is needless.

2) I’ve got Mark’s custom field file uploader extension and the File Manager extension and the default file manager on the publish form it isn’t used at all.

Having these two additional options to hide those buttons would be nice so that one could control exactly which of the “Preview,” “Quick Save,” and “File Upload” would show up depending on the project specs and other extensions that are used to handle that functionality.

Thanks!

Rob

       
Arden's avatar
Arden
23 posts
18 years ago
Arden's avatar Arden

This looks like a very extension, but unfortunately it doesn’t work exactly right for me.

The upload bit and the CP Home bit work just fine, though I would suggest adding a settings field to change the text of the upload link.

The Quick Save part is where I run into problems. For one, it doesn’t do anything. For another, you should change the settings language to remove subjectivity such as “baffling.” I don’t find the Quick Save button baffling at all, nor do any of the writers on my site. Also, I suggest removing the word “indecipherable” or changing it to something less subjective, like “obscure.”

I’d also like to have more control over which buttons are visible and what language they use, like Rob Q. I never use the Submit button, so I’d like to be able to hide that, and I’d like to be able to change the Quick Save button’s text to something else like Save or Update (but something I can choose).

At any rate, keep up the good work. I’m looking forward to 1.2. 😊

       
G - B - O's avatar
G - B - O
31 posts
18 years ago
G - B - O's avatar G - B - O

I have a small note: when one presses “preview”, the “old” buttons appear again instead of the ones intended …

Just so you know.

       
1 2 3 4 Last

Reply

Sign In To Reply

ExpressionEngine Home Features Pro Contact Version Support
Learn Docs University Forums
Resources Support Add-Ons Partners Blog
Privacy Terms Trademark Use License

Packet Tide owns and develops ExpressionEngine. © Packet Tide, All Rights Reserved.