We use cookies to improve your experience. No personal information is gathered and we don't serve ads. Cookies Policy.

ExpressionEngine Logo ExpressionEngine
Features Pricing Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University
Log In or Sign Up
Log In Sign Up
ExpressionEngine Logo
Features Pro new Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University Blog
  • Home
  • Forums

LG Social Bookmarks

Development and Programming

DEA's avatar
DEA
257 posts
17 years ago
DEA's avatar DEA

I’m getting the following error when I try to submit to Facebook:

missing { before function body
[removed](function(){ var a=window,b=document,c=encodeURIComponent,d=a.open('http://www.facebook.com/sharer.php?u='+c('http://www.troovy.com/finds/bombay-beach/')+'&t;='+c('Bombay Beach'),'sharer','toolbar=0,status=0,width=626,height=436,alwaysRaised=1');a.setTimeout(function(),300)})();
Line 1
       
Leevi Graham's avatar
Leevi Graham
1,143 posts
17 years ago
Leevi Graham's avatar Leevi Graham
I’m getting the following error when I try to submit to Facebook:
missing { before function body
[removed](function(){ var a=window,b=document,c=encodeURIComponent,d=a.open('http://www.facebook.com/sharer.php?u='+c('http://www.troovy.com/finds/bombay-beach/')+'&t;='+c('Bombay Beach'),'sharer','toolbar=0,status=0,width=626,height=436,alwaysRaised=1');a.setTimeout(function(),300)})();
Line 1

Right you are!

I think the issue is due to the inline js being deprecated. I would recommmend removing the facebook icon for now until a fix presents itself.

       
ayza's avatar
ayza
71 posts
17 years ago
ayza's avatar ayza

Hi Leevi,

thanks for a great module!

Please update the docs. I copied the code and got syntax errors on the page used it on because the ee-tags are still exp:social_bookmarks instead of exp:lg_social_bookmarks. The image pathway in the themes folder needs updating as well to img src=”/themes/cp_global_images/lg_social_bookmarks_module/favicons/{social_site_img_url}”

Might confuse newbies. Had me for a while.

😊

Ayza

       
Leevi Graham's avatar
Leevi Graham
1,143 posts
17 years ago
Leevi Graham's avatar Leevi Graham
Hi Leevi, thanks for a great module! Please update the docs. I copied the code and got syntax errors on the page used it on because the ee-tags are still exp:social_bookmarks instead of exp:lg_social_bookmarks. The image pathway in the themes folder needs updating as well to img src=”/themes/cp_global_images/lg_social_bookmarks_module/favicons/{social_site_img_url}” Might confuse newbies. Had me for a while. 😊 Ayza

Thanks for picking that up! The docs have been updated now.

       
Ric's avatar
Ric
49 posts
17 years ago
Ric's avatar Ric

Hi Leevi,

I love the social bookmarks plugin. Awesome work! One thing though, some of the output is not validating as xhtml strict or even transitional. It looks to be escaped and unencoded characters primarily, I highly encourage you to validate the output of the plugin’s output through the w3 validator to get specifics on the errors. You are so close to perfection my friend… just a little more…

       
Leevi Graham's avatar
Leevi Graham
1,143 posts
17 years ago
Leevi Graham's avatar Leevi Graham
Hi Leevi, I love the social bookmarks plugin. Awesome work! One thing though, some of the output is not validating as xhtml strict or even transitional. It looks to be escaped and unencoded characters primarily, I highly encourage you to validate the output of the plugin’s output through the w3 validator to get specifics on the errors. You are so close to perfection my friend… just a little more…

Funny you should mention that… I have a new version in testing that fixes this issue.

Cheers

       
Ric's avatar
Ric
49 posts
17 years ago
Ric's avatar Ric

YOU ROCK!!! I would be very happy to test, that is unless your close to release.

       
Ric's avatar
Ric
49 posts
17 years ago
Ric's avatar Ric

Hey Leevi any word on when that updated version of Social Bookmarks will be released, Thanks for any info!

       
Leevi Graham's avatar
Leevi Graham
1,143 posts
17 years ago
Leevi Graham's avatar Leevi Graham
Hey Leevi any word on when that updated version of Social Bookmarks will be released, Thanks for any info!

Working on a new site… It shouold be ready in a week or so.. Thanks for your patience

       
Ric's avatar
Ric
49 posts
17 years ago
Ric's avatar Ric

Thank You for the update, I’m really looking forward to the release.

       
Leevi Graham's avatar
Leevi Graham
1,143 posts
17 years ago
Leevi Graham's avatar Leevi Graham

Hey guys,

I am testing my new docs center on my site which includes an update to LG Social Bookmarks.

Go test the site and get the update: LG Social Bookmarks

Cheers

       
Ric's avatar
Ric
49 posts
17 years ago
Ric's avatar Ric

Leevi,

Simply Outstanding, fantastic Job all around!

       
Leevi Graham's avatar
Leevi Graham
1,143 posts
17 years ago
Leevi Graham's avatar Leevi Graham

I have just updated the module to URL encode entry titles in the social site url.

Grab it from my ExpressionEngine LG Social Bookmarks page.

       
Matt Johnson's avatar
Matt Johnson
45 posts
17 years ago
Matt Johnson's avatar Matt Johnson

Hey Leevi,

I installed your module and it was pretty easy to integrate, but for some reason its doing this:

http://www.homerobots.com/blog/comments/cuddly-lifelike-pleo-dinosaur-robot/http://del.icio.us/post?url=http://www.homerobots.com/http://www.homerobots.com/blog/comments/cuddly-lifelike-pleo-dinosaur-robot/&title=Cuddly, Lifelike Pleo Dinosaur

It’s putting the URL of the article in front of the social site url. I’ve been tinkering with it for the past hour now and can’t seem to figure out what the problem is.

I was just testing a few things and when I put anything in front of {social_site_url} it would do this:

<a href="http://{social_site_url}" title="Bookmark on: {social_site_name}">

__

http://http://del.icio.us/post?url=http://www.homerobots.com/http://www.homerobots.com/blog/comments/cuddly-lifelike-pleo-dinosaur-robot/&title=cuddly, lifelike pleo dinosaur/

here is how I’m integrating the module tag:

{exp:lg_social_bookmarks title="{title}" permalink="http://www.homerobots.com/{url_title_path="blog/comments"}"}_            <em>Enjoy this post? Share it with others.</em>_            <ul>_            {social_sites}_            <li>_            <a href="http://{social_site_url}" title="Bookmark on: {social_site_name}">_            /themes/cp_global_images/lg_social_bookmarks_module/favicons/{social_site_img_url}_            <span>{social_site_name}</span>_            </a>
            </li>
            {/social_sites}
            </ul>
            {/exp:lg_social_bookmarks}

Any help with this would be greatly appreciated!

       
Leevi Graham's avatar
Leevi Graham
1,143 posts
17 years ago
Leevi Graham's avatar Leevi Graham

Hey Matt,

You don’t need to add http:// before the {social_site_url}.

Check out the usage example on my site and try that. Then once you have the module working you can customise to your hearts content.

Cheers

Hey Leevi, I installed your module and it was pretty easy to integrate, but for some reason its doing this:
http://www.homerobots.com/blog/comments/cuddly-lifelike-pleo-dinosaur-robot/http://del.icio.us/post?url=http://www.homerobots.com/http://www.homerobots.com/blog/comments/cuddly-lifelike-pleo-dinosaur-robot/&title=Cuddly, Lifelike Pleo Dinosaur
It’s putting the URL of the article in front of the social site url. I’ve been tinkering with it for the past hour now and can’t seem to figure out what the problem is. I was just testing a few things and when I put anything in front of {social_site_url} it would do this:
<a href="http://{social_site_url}" title="Bookmark on: {social_site_name}">
__
http://http://del.icio.us/post?url=http://www.homerobots.com/http://www.homerobots.com/blog/comments/cuddly-lifelike-pleo-dinosaur-robot/&title=cuddly, lifelike pleo dinosaur/
__here is how I’m integrating the module tag:__
{exp:lg_social_bookmarks title="{title}" permalink="http://www.homerobots.com/{url_title_path="blog/comments"}"}_            <em>Enjoy this post? Share it with others.</em>_            <ul>_            {social_sites}_            <li>_            <a href="http://{social_site_url}" title="Bookmark on: {social_site_name}">_            /themes/cp_global_images/lg_social_bookmarks_module/favicons/{social_site_img_url}_            <span>{social_site_name}</span>_            </a>
            </li>
            {/social_sites}
            </ul>
            {/exp:lg_social_bookmarks}
Any help with this would be greatly appreciated!
       
First 3 4 5 6 7 Last

Reply

Sign In To Reply

ExpressionEngine Home Features Pro Contact Version Support
Learn Docs University Forums
Resources Support Add-Ons Partners Blog
Privacy Terms Trademark Use License

Packet Tide owns and develops ExpressionEngine. © Packet Tide, All Rights Reserved.