Bystrom Pagination Extension (EE 2.0 beta available)

Hi all,

A fix to the error is to change line 58 to:

$count = (isset($query->num_rows)) ? $query->num_rows: false;

-Matt

Michael,

I love this extension but believe I found a bug if the weblog entries tag has an offset. My tag has offset=1, limit=1, and the weblog has 4 entries.

Given that, without an offset there should be 4 pages, but with my offset of one there should only be 3 pages.

With your extension disabled, EE pagination gives 3 pages. With your extension on the pagination links show a 4th page. Navigating to this page comes up with blank results.

Hopefully that was all clear. Thanks again for the great extension.

-Matt

Hi hello all,

I’ve made som fixes on this little extension today. I can still not reproduce the “line 58” error but I’ve made changes to it from this forum so if there is still problem let me know. Changed the deprecated “ereg” in PHP 5.3 Fixed the “offset” bug.

New demo place: http://ee.michaelbystrom.com/bystrom_pagination/

Download: http://michaelbystrom.com/download/ee/

Michael,

Thanks for doing that.

This new build introduces a problem where pagination doesn’t work if dynamic=”off”. No pagination shows up at all. That wasn’t the case in the old version.

Can you take a look?

Thanks, Matt

Hello,

Are u sure that worked before it shouldn’t! Pagination doesn’t work if it is set to dynamic=“off” unless you hack EE. or i’m wrong?

-Michael

It definitely did work before. Pagination works with dynamic=off as long as you explicitly set the paginate= parameter.

Thanks, Matt

Hej,

Oh way cool i did not know aboout the paginate tag cool. Well I set it up as you described and it works fine on my server.

http://ee.michaelbystrom.com/bystrom_pagination

Is that what you mean or? Let me know

Cheers! -Michael

Is that a weblog:entries tag, with dynamic=”off”? On mine it doesn’t work. I have an offset=”1”, dynamic=”off”, and paginate=”both”.

Ok I set it up the same way and it looks funny with paginate=”both”. I included the source in the examples now so you can see.

I’ve re-set it to paginate=”bottom” so it works. I will look in to it little later!

-Micke

I investigated this a bit more. I noticed that I could go through all the pages once, but when I tried to go through them again they disappeared. Clearing the cache fixed it.

Looking into it more fully, if “Cache Dynamic Stack Queries?” is turned off in Global Weblog preferences, the problem is fixed. It turns out to have nothing to do with dynamic=”off”, and I apologize for that. (FYI this setting is the $conf[‘enable_sql_caching’] config variable).

I’m not sure why having that option on would do anything. It doesn’t affect the last version.

Nice! glad it works again for you, and thanks for letting me know so I woulden’t go crazy here 😊 I also found that paginate=“both” does not look funny a simple error in my CSS file.

Stay warm and good luck! -Michael

Michael– do you have any ideas on getting this thing to work with caching still on? And thanks again for your help here.

And obviously if not, I completely understand. This extension is invaluable and I appreciate all the work you’ve put into it.

Hehe no problem! I like to tinker with this when there is time. 😊

I took a peek at this “enable_sql_caching” is called and saved after the pagination is called. But I’n not sure thats the case. I’ll take a look at this a little later got some stuff needs to be done before x-mas holidays.

Cheers! -Michael