Stephen, thanks for this great add-on. Appreciate it. One niggly suggestion though: I’d make the Document Root section of Minify default in future updates of this. I’ve already had to set it up on two completely different servers and sites. Each time the reason it wasn’t rendering was because I had to explicitly explain the document root. 😊
Hi Lea,
One niggly suggestion though: I’d make the Document Root section of Minify default in future updates of this. I’ve already had to set it up on two completely different servers and sites. Each time the reason it wasn’t rendering was because I had to explicitly explain the document root.
I’m not quite following you… are you having problems with the DOCUMENT_ROOT definition inside Minify.php itself?
Stephen
I apologize. I was referencing this solution. When you add a section to the Minify config explicitly stating where the DOCUMENT_ROOT is manually.
I was referencing this solution. When you add a section to the Minify config explicitly stating where the DOCUMENT_ROOT is manually.
I’d completely forgotten about that… I’m sure it was even on a long-since misplaced to-do list at some point.
Thanks for reminding me, I’ll make a note (somewhere safe) to address this in the next version.
Cheers, Stephen
I’m having a similar issue with the extension disabling my main stylesheet and I’m not sure I am following how the earlier poster solved his issue.
here’s my code:
{exp:sl_combinator:combine_css disable="no" debug="no"}
<link rel='stylesheet' type='text/css' media='all' href='{stylesheet=site_css/stylesheet}'/>
{/exp:sl_combinator:combine_css}
Cheers, Paul
Hi Paul,
Ok, let’s walk back the cat shall we..?
That should be enough to point us in the right direction.
Cheers, Stephen
Walk back the cat:
To attempt to understand the true nature of a situation by reconstructing events chronologically from the present to the past.
I’ve been watching too many spy films.
Anyway, back to the problem at hand. I’m going to have to dig through the minify code a bit to see where the problem lies – expect me to pester you with more questions in the near future.
Cheers, Stephen
Hi Stephen,
Thanks for a great extension, it’s made a huge difference to the download speeds on a site i’m working on. (Especially the CSS - 35k to 8k - Nice!)
I have run into a couple of problems with the javascript side, they aren’t deal breakers by any stretch but if you have any suggestions i’d love to hear them!
Jquery: No matter what version of Jquery I use it doesn’t get processed, and breaks the remaining scripts too. I’ve tried the full version of 1.3.2 and the minified version with no luck. Because it’s quite large it would be great to get this down some more if possible, or even to just get it included in the single http request without compression would help.
Cufon I’m using Cufon (http://cufon.shoqolate.com/generate/) to add a custom font on the site, which uses two files - cufon.yui.js (15k) for the processing and cufonfontname.js (50k - ouch!) which holds the font info. I’m not too concerned about these, but just in case someone else is using Cufon in the future and runs into trouble I thought i’d flag it here.
Thanks again for your work on this, very handy.
Cheers,
Cormac
Hi birdie,
No matter what version of Jquery I use it doesn’t get processed, and breaks the remaining scripts too. I’ve tried the full version of 1.3.2 and the minified version with no luck. Because it’s quite large it would be great to get this down some more if possible, or even to just get it included in the single http request without compression would help.
Ok, let’s start with the obvious question: are all the scripts you’re requesting being served from your site (i.e. not a remote server, or a subdomain)?
Also, are you seeing any JavaScript errors when the scripts are compressed, or is everything just failing silently? If you have a URL I could look at, that might help.
That’ll do for starters.
Cheers, Stephen
Hi Stephen,
All the scripts are hosted on my website server, in a folder called “scripts”, there are no subdomains or anything like that involved.
Here is my sl tag, with all scripts except Cufon: http://skitch.com/birdie/bt6qm/head-scripts.php
(The forum removed my script tags so hopefully the image will do!)
I don’t get any errors when Jquery isn’t included.
When I add Jquery, however, I get a 400 Bad Request error. I can see the Jquery file if I look via the path though: http://mysite.com/utils/min/index.php?f=scripts/jquery-1.3.2.min.js&debug=1
I am using the include method to remove index.php, in case that has anything to do with it, here is my .htaccess content:
RewriteEngine On
RewriteCond $1 ^(member|includes|site|info|work|about|clients|blog|contact|quote|P[0-9]{2,8}) [NC]
RewriteRule ^(.*)$ /index.php/$1 [L]
I’ll PM you a link to the site so you can take a look, and will leave it with jquery included so you can see the error.
Thanks for your help with this, much appreciated!
Cormac
Hi Cormac,
Apologies for the delay in replying — far too many looming deadlines.
I’ve tracked down the problem (I think). By default Minify sets the maximum number of files that can be combined and compressed in one hit to 10 (I’m not entirely sure why).
You can either split the compressing into two batches, or open up the /utils/config.php file, and change this line:
$min_serveOptions['minApp']['maxFiles'] = 10;
I’d also recommend disabling debugging, unless you have a specific need for it, as it can (very occasionally) introduce JavaScript errors.
Let me know how that works out for you.
Cheers, Stephen
Packet Tide owns and develops ExpressionEngine. © Packet Tide, All Rights Reserved.